[llvm] r238369 - AsmPrinter: Stop exposing underlying DIEValue list, NFC

Duncan P. N. Exon Smith dexonsmith at apple.com
Thu May 28 12:02:13 PDT 2015

Thanks both.  Fixed in r238456.

> On 2015-May-27, at 19:21, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> According to
> http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
> The preferred one is foo_begin/foo_end.
> Cheers,
> Rafael
> On 27 May 2015 at 20:09, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>>> On 2015 May 27, at 16:19, David Blaikie <dblaikie at gmail.com> wrote:
>>> (alternatively - (optionally add range-based APIs for anything you currently need begin/end for, and) skip begin/end in favor of using the range accessor below)
>> Yeah, it'd be nice to get rid of these entirely.  But since I
>> tend to need to basically write them anyway to build the range
>> accessor I usually just expose them by default.
>> Probably easy to delete though.  I'll have a go.

Not so easy yet, since we currently need to compute an index.  I'll
have another go once the patch to convert `DIE::Value`s to a linked
list has landed.

More information about the llvm-commits mailing list