[PATCH] Thumb2: Modify codegen for memcpy intrinsic to prefer LDM/STM.

John Brawn john.brawn at arm.com
Thu May 28 04:20:54 PDT 2015


One minor nitpick, otherwise looks good to me.


================
Comment at: lib/Target/ARM/Thumb2SizeReduction.cpp:128
@@ -127,2 +127,3 @@
   { ARM::t2LDMIA_UPD,ARM::tLDMIA_UPD,ARM::tPOP,0,   0,   1,   1,  1,1, 0,1,0 },
   // ARM::t2STM (with no basereg writeback) has no Thumb1 equivalent
+  { ARM::t2STMIA, ARM::tSTMIA_UPD, 0,          0,   0,   1,   1,  1,1, 0,1,0 },
----------------
This comment should be updated - tSTMIA_UPD isn't the equivalent of t2STMIA, but the difference is correctly handled elsewhere.

http://reviews.llvm.org/D9508

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list