[lld] r238383 - Add PHDR and FILL parsing.

Davide Italiano davide at freebsd.org
Wed May 27 17:28:34 PDT 2015

On Wed, May 27, 2015 at 5:14 PM, Michael J. Spencer
<bigcheesegs at gmail.com> wrote:
> Author: mspencer
> Date: Wed May 27 19:14:58 2015
> New Revision: 238383
> URL: http://llvm.org/viewvc/llvm-project?rev=238383&view=rev
> Log:
> Add PHDR and FILL parsing.
> Added:
>     lld/trunk/test/LinkerScript/phdrs-sections.test
> Modified:
>     lld/trunk/include/lld/ReaderWriter/LinkerScript.h
>     lld/trunk/lib/ReaderWriter/LinkerScript.cpp
>     lld/trunk/test/LinkerScript/sections.test

I didn't review this carefully but from a quick skim it seems this
does not implement the semantic action associated.
If you plan to commit that as a separate commit, is fine, but I think
that as general rule we should try to reduce the number of constructs
that don't have a semantic action associated, and for newly introduced
constructs could try to implement both parsing and semantic at the
same time. I have a feeling that a decent amount of this code in
LinkerScript sits almost unused because after parsing no action is



More information about the llvm-commits mailing list