[llvm] r238359 - AsmPrinter: Introduce DIEValue.def, NFC

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed May 27 14:15:43 PDT 2015


Author: dexonsmith
Date: Wed May 27 16:15:43 2015
New Revision: 238359

URL: http://llvm.org/viewvc/llvm-project?rev=238359&view=rev
Log:
AsmPrinter: Introduce DIEValue.def, NFC

Use a .def macro file to iterate through the various subclasses of
`DIEValue`.

Added:
    llvm/trunk/include/llvm/CodeGen/DIEValue.def
Modified:
    llvm/trunk/include/llvm/CodeGen/DIE.h
    llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp

Modified: llvm/trunk/include/llvm/CodeGen/DIE.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/DIE.h?rev=238359&r1=238358&r2=238359&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/DIE.h (original)
+++ llvm/trunk/include/llvm/CodeGen/DIE.h Wed May 27 16:15:43 2015
@@ -111,16 +111,8 @@ public:
 class DIEValue {
 public:
   enum Type {
-    isInteger,
-    isString,
-    isExpr,
-    isLabel,
-    isDelta,
-    isEntry,
-    isTypeSignature,
-    isBlock,
-    isLoc,
-    isLocList,
+#define HANDLE_DIEVALUE(T) is##T,
+#include "llvm/CodeGen/DIEValue.def"
   };
 
 private:

Added: llvm/trunk/include/llvm/CodeGen/DIEValue.def
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/DIEValue.def?rev=238359&view=auto
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/DIEValue.def (added)
+++ llvm/trunk/include/llvm/CodeGen/DIEValue.def Wed May 27 16:15:43 2015
@@ -0,0 +1,29 @@
+//===- llvm/CodeGen/DIEValue.def - DIEValue types ---------------*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// Macros for running through all types of DIEValue.
+//
+//===----------------------------------------------------------------------===//
+
+#if !(defined HANDLE_DIEVALUE)
+#error "Missing macro definition of HANDLE_DIEVALUE"
+#endif
+
+HANDLE_DIEVALUE(Integer)
+HANDLE_DIEVALUE(String)
+HANDLE_DIEVALUE(Expr)
+HANDLE_DIEVALUE(Label)
+HANDLE_DIEVALUE(Delta)
+HANDLE_DIEVALUE(Entry)
+HANDLE_DIEVALUE(TypeSignature)
+HANDLE_DIEVALUE(Block)
+HANDLE_DIEVALUE(Loc)
+HANDLE_DIEVALUE(LocList)
+
+#undef HANDLE_DIEVALUE

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp?rev=238359&r1=238358&r2=238359&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp Wed May 27 16:15:43 2015
@@ -193,40 +193,20 @@ void DIE::dump() {
 
 void DIEValue::EmitValue(const AsmPrinter *AP, dwarf::Form Form) const {
   switch (Ty) {
-#define EMIT_VALUE_IMPL(Kind)                                                  \
-  case is##Kind:                                                               \
-    cast<DIE##Kind>(this)->EmitValueImpl(AP, Form);                            \
+#define HANDLE_DIEVALUE(T)                                                     \
+  case is##T:                                                                  \
+    cast<DIE##T>(this)->EmitValueImpl(AP, Form);                               \
     break;
-    EMIT_VALUE_IMPL(Integer)
-    EMIT_VALUE_IMPL(String)
-    EMIT_VALUE_IMPL(Expr)
-    EMIT_VALUE_IMPL(Label)
-    EMIT_VALUE_IMPL(Delta)
-    EMIT_VALUE_IMPL(Entry)
-    EMIT_VALUE_IMPL(TypeSignature)
-    EMIT_VALUE_IMPL(Block)
-    EMIT_VALUE_IMPL(Loc)
-    EMIT_VALUE_IMPL(LocList)
-#undef EMIT_VALUE_IMPL
+#include "llvm/CodeGen/DIEValue.def"
   }
 }
 
 unsigned DIEValue::SizeOf(const AsmPrinter *AP, dwarf::Form Form) const {
   switch (Ty) {
-#define SIZE_OF_IMPL(Kind)                                                     \
-  case is##Kind:                                                               \
-    return cast<DIE##Kind>(this)->SizeOfImpl(AP, Form);
-    SIZE_OF_IMPL(Integer)
-    SIZE_OF_IMPL(String)
-    SIZE_OF_IMPL(Expr)
-    SIZE_OF_IMPL(Label)
-    SIZE_OF_IMPL(Delta)
-    SIZE_OF_IMPL(Entry)
-    SIZE_OF_IMPL(TypeSignature)
-    SIZE_OF_IMPL(Block)
-    SIZE_OF_IMPL(Loc)
-    SIZE_OF_IMPL(LocList)
-#undef SIZE_OF_IMPL
+#define HANDLE_DIEVALUE(T)                                                     \
+  case is##T:                                                                  \
+    return cast<DIE##T>(this)->SizeOfImpl(AP, Form);
+#include "llvm/CodeGen/DIEValue.def"
   }
   llvm_unreachable("Unknown DIE kind");
 }
@@ -234,21 +214,11 @@ unsigned DIEValue::SizeOf(const AsmPrint
 #ifndef NDEBUG
 void DIEValue::print(raw_ostream &O) const {
   switch (Ty) {
-#define PRINT_IMPL(Kind)                                                       \
-  case is##Kind:                                                               \
-    cast<DIE##Kind>(this)->printImpl(O);                                       \
+#define HANDLE_DIEVALUE(T)                                                     \
+  case is##T:                                                                  \
+    cast<DIE##T>(this)->printImpl(O);                                          \
     break;
-    PRINT_IMPL(Integer)
-    PRINT_IMPL(String)
-    PRINT_IMPL(Expr)
-    PRINT_IMPL(Label)
-    PRINT_IMPL(Delta)
-    PRINT_IMPL(Entry)
-    PRINT_IMPL(TypeSignature)
-    PRINT_IMPL(Block)
-    PRINT_IMPL(Loc)
-    PRINT_IMPL(LocList)
-#undef PRINT_IMPL
+#include "llvm/CodeGen/DIEValue.def"
   }
 }
 





More information about the llvm-commits mailing list