[PATCH] Disable x86 tail call optimization under PIC mode

[Xinliang David Li]

This sounds good to me.

David

On Wed, May 27, 2015 at 11:14 AM, Reid Kleckner <rnk at google.com> wrote:
> I'm coming around to the position that we should simply disable this
> optimization for PIC calls to symbols with default visibility. The current
> change disables all tail calls when generating PIC code, which is
> undesirable.
>
> We can add a flag later if someone asks, and call it
> -f[no-]optimize-pic-sibling-calls.
>
> On Wed, May 27, 2015 at 10:34 AM, David <davidxl at google.com> wrote:
>>
>> Changing the default may affect users who depend on the current behavior
>> which has been the case for a couple of releases.   Another possible
>> solution is to emit a warning for cases like this so that debugging similar
>> issues in the future will become easier.
>>
>>
>> http://reviews.llvm.org/D9799
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>