[llvm] r238335 - Fix PR 23499 - Avoid multiple profile counters for functions in comdat sections.

Diego Novillo dnovillo at google.com
Wed May 27 10:06:22 PDT 2015

On Wed, May 27, 2015 at 1:04 PM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:
>> On 2015 May 27, at 09:57, Diego Novillo <dnovillo at google.com> wrote:
>> On Wed, May 27, 2015 at 12:51 PM, Duncan P. N. Exon Smith
>> <dexonsmith at apple.com> wrote:
>>> Testcase?
>> In compiler-rt. This needs linking and runtime.
> Okay, but:
>   - You should have mentioned that test in your commit message :).

Yeah. It was in my patch proposal message. The commit log had other wording.

>   - You still need a test in LLVM that the right IR gets generated.
>     Compiler-RT is an okay place for full-flow tests for PGO -- does
>     it all work? -- but we should have a local test that this pass
>     is generating the right IR.  I think the right place is
>     test/Instrumentation/InstrProfiling/.

I'll add one.

>> But my git tree is busted, git svn is not working in compiler-rt, for
>> me. I need to unconfuse it before I can commit.
> Not exactly sure what's wrong, but IME when this doesn't fix it:

Yes. I've run into this from time to time.

More information about the llvm-commits mailing list