Fix PR 23499

Diego Novillo dnovillo at
Wed May 27 09:01:32 PDT 2015

On Wed, May 27, 2015 at 11:51 AM, Justin Bogner <mail at> wrote:

> Is setting the comdat on Data sufficient, or should we do it for
> Counters (and possibly even name) also? I guess that could lead to some
> more space savings, even if it doesn't have a visible effect.

It's sufficient, but good point about the space savings.  I'll add them.

> We usually wrap comments a little wider than this, and there's no need
> to refer to the bug number here.

Really?  Wow, OK.  I find these references very valuable for future
archaeology. But, sure, I'll remove it.

I guess, leaving a reference to it in the commit log is OK?


More information about the llvm-commits mailing list