[PATCH] [LLD] Add a new PE/COFF port

[Peter Collingbourne]

Clang build fixes: F533032: clang.diff <http://reviews.llvm.org/F533032>


================
Comment at: COFF/InputFiles.cpp:242
@@ +241,3 @@
+
+  uint16_t TypeInfo = read16le(Buf + offsetof(ImportHeader, TypeInfo));
+  int Type = TypeInfo & 0x3;
----------------
Here (and in a few other places) you are making assumptions about the host system's data layout. This may be a largely theoretical problem though.

================
Comment at: COFF/SymbolTable.cpp:88
@@ +87,3 @@
+      if (!isa<Defined>(Sym->Body)) {
+        llvm::errs() << "undefined symbol: " << Undef->getName() << "\n";
+        Ret = true;
----------------
Should this diagnose that `Undef` is undefined because `Sym->Body` is undefined?

================
Comment at: test/COFF/driver.test:3
@@ +2,3 @@
+# RUN: FileCheck -check-prefix=MISSING %s < %t.log
+MISSING: nosuchfile.obj: no such file or directory
+
----------------
On Linux this reads "nosuchfile.obj: No such file or directory" (capital N).

http://reviews.llvm.org/D10036

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/