[lld] r238115 - [ELF] Fix lld when no unique sections is used

[Rui Ueyama]

On Tue, May 26, 2015 at 3:16 PM, Michael Spencer <bigcheesegs at gmail.com>
wrote:

> On Tue, May 26, 2015 at 2:18 PM, Rui Ueyama <ruiu at google.com> wrote:
> > Yes we should fix it if it can't handle valid objects, but I think we
> > probably start considering checking in object files (as opposed to
> checking
> > in yaml files) is the right thing, as IIRC Rafael said before. Object
> files
> > are the input for the linker, so in order to get a precise control over
> the
> > input, it's better to use object files themselves.
>
> I would rather we not use non-human readable inputs for testing. It
> makes it difficult to tell what's being tested and what the file
> actually represents. The intent of yaml2obj is to be able to represent
> (almost) any valid ELF file, and some invalid ones. I'll add support
> for it.
>

Human-readable files are indeed good for human, but there are many file
formats that we only want to read but don't want to write, such as old .a
file headers, so I don't think it's always a good idea to write a tool to
convert textual formats into binary. For human readability, I think we can
check in source files if it makes sense (for example, if you create an
object file from an assembly, you can check both files.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150526/126b34c2/attachment.html>