[PATCH] Refactor: Simplify boolean conditional return statements in lib/Target/Mips

Richard legalize at xmission.com
Mon May 25 09:35:01 PDT 2015


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:935
@@ -935,2 +934,3 @@
+    return (R0 == Mips::A1 && R1 == Mips::A2) ||
         (R0 == Mips::A1 && R1 == Mips::A3) ||
         (R0 == Mips::A2 && R1 == Mips::A3) ||
----------------
craig.topper wrote:
> Fix indentation
Fixed.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1880
@@ -1887,1 +1879,3 @@
+  return loadImmediate(ImmOp.getImm(), DstRegOp.getReg(), Mips::NoRegister,
+                    Is32BitImm, IDLoc, Instructions);
 }
----------------
craig.topper wrote:
> Fix indentation
Fixed.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1900
@@ -1910,1 +1899,3 @@
+  return loadImmediate(ImmOp.getImm(), DstRegOp.getReg(), SrcRegOp.getReg(),
+                    Is32BitImm, IDLoc, Instructions);
 }
----------------
craig.topper wrote:
> Fix indentation
Fixed.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1918
@@ -1931,1 +1917,3 @@
+  return loadImmediate(ImmOp.getImm(), DstRegOp.getReg(), Mips::NoRegister,
+                    Is32BitImm, IDLoc, Instructions);
 }
----------------
craig.topper wrote:
> Fix indentation
Fixed.

http://reviews.llvm.org/D9982

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list