[PATCH] Disable x86 tail call optimization under PIC mode

Reid Kleckner rnk at google.com
Fri May 22 11:23:09 PDT 2015


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2759
@@ +2758,3 @@
+  if (Subtarget->isPICStyleGOT())
+    isTailCall = IsMustTail = false;
+
----------------
We can't do this, musttail guarantees that a tail call will occur. I think the old behavior of forcing relocations to be resolved eagerly was preferable. If we cannot honor musttail, we must report an error somehow.

http://reviews.llvm.org/D9799

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list