[PATCH] CodeGen: Use mop_iterator instead of MIOperands/ConstMIOperands

Quentin Colombet qcolombet at apple.com
Fri May 22 10:47:08 PDT 2015


Hi Matthias,

Although both iterators have the same capabilities, I found it convenient to use one or another depending on the context.
That being said, I do not feel strongly about deprecating one, if Andy agrees.

Anyhow, some of the for range based loops looks good, the other ones not such much (that's why I am a bit reluctant for the whole change).

Cheers,
-Quentin


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/EarlyIfConversion.cpp:229
@@ -228,3 +228,3 @@
     // Check for any dependencies on Head instructions.
-    for (MIOperands MO(I); MO.isValid(); ++MO) {
-      if (MO->isRegMask()) {
+    for (const MachineOperand MO : I->operands()) {
+      if (MO.isRegMask()) {
----------------
While you are here, maybe we can use a reference for this one.

http://reviews.llvm.org/D9932

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list