[llvm] r236642 - MC: Skip names of temporary symbols in object streamer

Duncan P. N. Exon Smith dexonsmith at apple.com
Thu May 21 12:25:56 PDT 2015


> On 2015-May-21, at 12:17, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> 
>> +  if (IsTemporary && AlwaysAddSuffix && !UseNamesOnTempLabels)
>> +    return new (*this) MCSymbol("", true);
> 
> Why do you need the AlwaysAddSuffix?


IIRC, I tried it without and got some test failures; I assume some
symbols make it to the object file with `L` or `l` prefixes and need
to be stripped by the linker.  I didn't look too deeply, since this
got me the same memory win (there must not be many temp symbols with
`!AlwaysAddPrefix`).

> Longer term one idea would be to completely remove the temp names and
> renaming from MCContext and move that logic to the MCAsmStreamer.

I like this idea.



More information about the llvm-commits mailing list