[PATCH] AsmParser: Require null terminator in the created memory buffer.

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed May 20 13:13:58 PDT 2015


> On 2015 May 20, at 13:03, Alex Lorenz <arphaman at gmail.com> wrote:
> 
> I went back to the patch that requires a terminating null character again, as the range
> checks in LLLexer would have to be introduced in a lot of places.
> 
> I updated the unittest to include a passing testcase as Duncan suggested.
> 
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D9883
> 
> Files:
>  lib/AsmParser/Parser.cpp
>  unittests/AsmParser/AsmParserTest.cpp
>  unittests/AsmParser/CMakeLists.txt
>  unittests/AsmParser/Makefile
>  unittests/CMakeLists.txt
>  unittests/Makefile
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D9883.26172.patch>

Thanks for checking.  This LGTM if Matthias agrees.



More information about the llvm-commits mailing list