[PATCH] DAGCombiner: Continue combining if FoldConstantArithmetic() fails.

[hfinkel at anl.gov]

REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1600
@@ +1599,3 @@
+/// ContantSDNode pointer else nullptr.
+static ConstantSDNode *asNonOpaqueConstant(SDValue N) {
+  ConstantSDNode *Const = dyn_cast<ConstantSDNode>(N);
----------------
Our general convention seems to be to name functions like this 'getAs<Name>', not 'as<Name>', so I think getAsNonOpaqueConstant would be better.

Otherwise, LGTM.

http://reviews.llvm.org/D6946

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/