[PATCH] Fix memory-dereferenceable.ll test

Artur Pilipenko apilipenko at azulsystems.com
Wed May 20 05:31:35 PDT 2015


Hi sanjoy,

One of the testcases introduced by D9365 had incorrect !dereferenceable metadata on load. It must fail but it doesn't due to incorrect order of CHECK/CHECK-NOT commands in test. Fixed both.

http://reviews.llvm.org/D9877

Files:
  test/Analysis/ValueTracking/memory-dereferenceable.ll

Index: test/Analysis/ValueTracking/memory-dereferenceable.ll
===================================================================
--- test/Analysis/ValueTracking/memory-dereferenceable.ll
+++ test/Analysis/ValueTracking/memory-dereferenceable.ll
@@ -16,12 +16,12 @@
 ; CHECK: %alloca
 ; CHECK: %dparam
 ; CHECK: %relocate
-; CHECK: %d4_load
-; CHECK: %d_or_null_non_null_load
 ; CHECK-NOT: %nparam
 ; CHECK-NOT: %nd_load
+; CHECK: %d4_load
 ; CHECK-NOT: %d2_load
 ; CHECK-NOT: %d_or_null_load
+; CHECK: %d_or_null_non_null_load
 entry:
     %globalptr = getelementptr inbounds [6 x i8], [6 x i8]* @globalstr, i32 0, i32 0
     %load1 = load i8, i8* %globalptr
@@ -35,7 +35,7 @@
     %load5 = load i32, i32 addrspace(1)* %nparam
 
     ; Load from a non-dereferenceable load
-    %nd_load = load i32*, i32** @globali32ptr, !dereferenceable !0
+    %nd_load = load i32*, i32** @globali32ptr
     %load6 = load i32, i32* %nd_load
 
     ; Load from a dereferenceable load

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9877.26145.patch
Type: text/x-patch
Size: 968 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150520/e5a8f4ce/attachment.bin>


More information about the llvm-commits mailing list