[PATCH] Ensure FDE reads the correct CIE when relocating the LSDA.

[Robinson, Paul]

Those acronyms occur in LLVM as well (see llvm/lib/MC/MCDwarf.cpp), so should not go into an lld-specific lexicon.
--paulr

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Sean Silva
Sent: Tuesday, May 19, 2015 3:31 PM
To: Lang Hames
Cc: llvm-commits at cs.uiuc.edu; reviews+D9783+public+982a29ea99dd4936 at reviews.llvm.org
Subject: Re: [PATCH] Ensure FDE reads the correct CIE when relocating the LSDA.



On Mon, May 18, 2015 at 4:12 PM, Lang Hames <lhames at gmail.com<mailto:lhames at gmail.com>> wrote:
It is. I'm not sure they fit properly in Lexicon though: These are all acronyms from the DWARF standard, and no other acronyms from that standard are listed there.


Lexicon.rst is basically a bunch of random acronyms that you might run into on the llvm mailing lists (e.g. "NFC"). I think it will fit in just fine.

-- Sean Silva


I'll look around and see if they fit anywhere else. If not, perhaps lld needs its own Lexicon.

- Lang.

On Mon, May 18, 2015 at 3:52 PM, Sean Silva <chisophugis at gmail.com<mailto:chisophugis at gmail.com>> wrote:
That's a lot of acronyms. Would you mind dropping them in http://llvm.org/docs/Lexicon.html (docs/Lexicon.rst)?

-- Sean Silva

On Thu, May 14, 2015 at 3:43 PM, Lang Hames <lhames at gmail.com<mailto:lhames at gmail.com>> wrote:
Hi ruiu,

Commit r237222 taught lld to relocate the LSDA field of FDE entries in MachO eh-frames, but it contained a bug: Each FDE would refer to the augmentation data string from the most recently parsed CIE field, note the CIE pointed to by the FDE. This patch fixes that.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9783

Files:
  lib/ReaderWriter/MachO/MachONormalizedFileToAtoms.cpp
  test/mach-o/parse-eh-frame-relocs-x86_64.yaml

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150519/c3b43396/attachment.html>