[PATCH] reenable gep merging in some constrainted cases

[Xinliang David Li]

I agree. I remembered the plan was to disable the blind GEP merging which
have shown big damages to performance, reported independently by different
users, and tune the  heuristic to enable beneficial merging selectively.

David


On Tue, May 19, 2015 at 3:10 PM, Wei Mi <wmi at google.com> wrote:

> Hi Quentin,
>
> Yes, it is a tuning of the heuristic from http://reviews.llvm.org/D8911.
>
> Because the regression I saw here has much smaller negative impact
> compared with the original negative impact of gep merging, is it
> possible that we leave r235455 there while we discuss a better fix?
> Because in this way we can check is there any other analysis affected
> by disabling gep merging.
>
> Thanks,
> Wei.
>
> On Tue, May 19, 2015 at 3:00 PM, Quentin Colombet <qcolombet at apple.com>
> wrote:
> > Hi Wei,
> >
> > Correct me if I am wrong, but this is a tuning of the heuristic from
> http://reviews.llvm.org/D8911, right?
> >
> > Given that you actually see a regression now (and the fact that after
> discussing with Chandler, I am not convinced the initial change makes
> sense), I would suggest that you revert r235455 and that we start again the
> discussion on how to properly fix that.
> >
> > Thanks,
> > -Quentin
> >
> >
> > REPOSITORY
> >   rL LLVM
> >
> > http://reviews.llvm.org/D9865
> >
> > EMAIL PREFERENCES
> >   http://reviews.llvm.org/settings/panel/emailpreferences/
> >
> >
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150519/fe9d90ae/attachment.html>