[PATCH] [Refactor] Replace RegionPasses by FunctionPasses

Tue May 19 09:21:51 PDT 2015

> In http://reviews.llvm.org/D7986#136089, @grosser wrote:

> 

> > The patch Zino refers to was committed in 231485. It did not have a large impact on our LNT performance builders (which do not seem to even see the slowdown we try to address here). However, on my laptop I was able to reproduce this performance issue in a cmake release build and Zino's patch fixes it at least for tramp3d-v4 nicely. Johannes, could you check if there is still a performance issue that needs to be addressed?

> 

> 

> How can the buildbots run e.g., tramp3d in 9sec when it takes for me with lnt

>  [1,2] >40sec for one of the source files alone. This is not new but they do

>  perform that good all the time... I'm puzzled here...

Looking at the buildbot history, it seems we never had compile-times below 35 seconds. Can you remember where you got these 9 seconds from?

http://llvm.org/perf/db_default/v4/nts/graph?highlight_run=27014&plot.1349=23.1349.1

Johannes, I also wonder what you plan to do with the patch here. It seems the original compile time issues that it meant to fix have been resolved. Are you still planning to submit this patch for other reasons or should we close this review for now?

http://reviews.llvm.org/D7986

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/