[PATCH] Add a GCStrategy for CoreCLR

Philip Reames listmail at philipreames.com
Mon May 18 16:48:52 PDT 2015


LGTM.

I would ask that you update the builtin GC documentation (http://llvm.org/docs/GarbageCollection.html#built-in-gc-strategies) to include your newly added one.  Doing this as a follow on commit is fine.


================
Comment at: lib/CodeGen/CoreCLRGC.cpp:44
@@ +43,3 @@
+    PointerType *PT = cast<PointerType>(V->getType());
+    // For the sake of this example GC, we arbitrarily pick addrspace(1) as our
+    // GC managed heap.  We know that a pointer into this heap needs to be
----------------
Comment is stale, please fix.

================
Comment at: lib/CodeGen/CoreCLRGC.cpp:54
@@ +53,3 @@
+
+static GCRegistry::Add<CoreCLRGC> X("coreclr",
+                                    "CoreCLR-compatible GC");
----------------
This is the registration mechanism you were asking about.  It's a nasty misuse of initializers, but I haven't gotten around to ripping it apart and rewriting yet.

http://reviews.llvm.org/D9767

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list