[PATCH] MachineInstr: Change return value of getOpcode() to unsigned. NFC

Matthias Braun matze at braunis.de
Mon May 18 12:17:24 PDT 2015


This was previously returning int. However there are no negative opcode
numbers and more importantly this was needlessly different from
MCInstrDesc::getOpcode() (which even is the value returned here) and
SDValue::getOpcode()/SDNode::getOpcode().

The result was different parts of the code have been already using unsigned for opcode numbers while others used int.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9832

Files:
  include/llvm/CodeGen/MachineInstr.h
  include/llvm/Target/TargetInstrInfo.h
  lib/CodeGen/MachineVerifier.cpp
  lib/CodeGen/PrologEpilogInserter.cpp
  lib/CodeGen/ShrinkWrap.cpp
  lib/CodeGen/TargetInstrInfo.cpp
  lib/Target/AArch64/AArch64AdvSIMDScalarPass.cpp
  lib/Target/AArch64/AArch64ConditionOptimizer.cpp
  lib/Target/AArch64/AArch64FrameLowering.cpp
  lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
  lib/Target/ARM/ARMBaseInstrInfo.cpp
  lib/Target/ARM/ARMBaseInstrInfo.h
  lib/Target/ARM/ARMConstantIslandPass.cpp
  lib/Target/ARM/ARMLoadStoreOptimizer.cpp
  lib/Target/SystemZ/SystemZInstrInfo.cpp
  lib/Target/X86/X86CallFrameOptimization.cpp
  lib/Target/X86/X86FrameLowering.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9832.25995.patch
Type: text/x-patch
Size: 19558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150518/2e7016b7/attachment.bin>


More information about the llvm-commits mailing list