[PATCH] Re: Fix llvm::BumpPtrAllocatorImpl::Reset()

[Hans Wennborg]

r237588

Cheers,
Hans

On Mon, May 18, 2015 at 9:42 AM, Kal <b17c0de at gmail.com> wrote:
> I don't have commit access. Please commit.
>
> Am 18.05.15 um 18:20 schrieb Hans Wennborg:
>
>> Looks great, thanks!
>>
>> Do you have commit access, or would you like me to commit it for you?
>>
>> Cheers,
>> Hans
>>
>> On Mon, May 18, 2015 at 4:13 AM, Kal <b17c0de at gmail.com> wrote:
>>>
>>> Enjoy
>>>
>>> Am 14.05.15 um 19:45 schrieb Hans Wennborg:
>>>
>>>> On Mon, May 11, 2015 at 10:37 AM, Kal <b17c0de at gmail.com> wrote:
>>>>>
>>>>> BumpPtrAllocator's Reset doesn't act as documented if Slaps.size() == 0
>>>>> but
>>>>> CustomSizedSlabs.size() != 0.
>>>>
>>>> Nice find!
>>>>
>>>>>        DeallocateCustomSizedSlabs();
>>>>>        CustomSizedSlabs.clear();
>>>>
>>>> How about just moving these to the top of the function, before the "if
>>>> (Slabs.empty()" check?
>>>>
>>>> Could we also add a test in unittests/Support/AllocatorTest.cpp?
>>>>
>>>> Cheers,
>>>> Hans
>>>
>>>
>