[PATCH] compile time improvement for MachineSink

Matthias Braun matze at braunis.de
Fri May 15 16:28:24 PDT 2015


LGTM with the following nitpick adressed:


================
Comment at: lib/CodeGen/MachineSink.cpp:773-774
@@ -761,2 +772,4 @@
   // used registers.
+  // Only record registers now, clear any kill flags later,
+  // since it's possible that they are no longer correct.
   for (MachineOperand &MO : MI->operands()) {
----------------
No need to state the fact that the flags may be incorrect a second time. I think it is enough to use something simple as:

 if(MO.isReg() && MO.isUse())
    RegsToClearKillFlags.set(MO.getReg()); // Remember to clear kill flags later.

http://reviews.llvm.org/D9719

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list