[llvm] r237449 - NFC - Test case invokes llc on a file rather than redirected from a file.

[David Blaikie]

On Fri, May 15, 2015 at 8:39 AM, Hal Finkel <hfinkel at anl.gov> wrote:

> ----- Original Message -----
> > From: "Nemanja Ivanovic" <nemanja.i.ibm at gmail.com>
> > To: llvm-commits at cs.uiuc.edu
> > Sent: Friday, May 15, 2015 10:29:54 AM
> > Subject: [llvm] r237449 - NFC - Test case invokes llc on a file rather
> than   redirected from a file.
> >
> > Author: nemanjai
> > Date: Fri May 15 10:29:53 2015
> > New Revision: 237449
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=237449&view=rev
> > Log:
> > NFC - Test case invokes llc on a file rather than redirected from a
> > file.
> >
> > This has caused some local failures.
>
> Why?
>

I'd be curious to know too.

The usual culprit is that if you run LLVM tools with a filename, it prints
that filename as the name of the module in the output and sometimes that
can catch FileCheck rules by accident. I don't know if that's what's going
on in this instance, though.


>
>  -Hal
>
> > Updating the test case to be
> > more
> > like the majority of the similar test cases.
> > Committing on behalf of Hubert Tong (hstong at ca.ibm.com).
> >
> > Modified:
> >     llvm/trunk/test/Transforms/LoopVectorize/X86/vectorization-remarks.ll
> >
> > Modified:
> > llvm/trunk/test/Transforms/LoopVectorize/X86/vectorization-remarks.ll
> > URL:
> >
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopVectorize/X86/vectorization-remarks.ll?rev=237449&r1=237448&r2=237449&view=diff
> >
> ==============================================================================
> > ---
> > llvm/trunk/test/Transforms/LoopVectorize/X86/vectorization-remarks.ll
> > (original)
> > +++
> > llvm/trunk/test/Transforms/LoopVectorize/X86/vectorization-remarks.ll
> > Fri May 15 10:29:53 2015
> > @@ -5,7 +5,7 @@
> >  ; This code has all the !dbg annotations needed to track source line
> >  information,
> >  ; but is missing the llvm.dbg.cu annotation. This prevents code
> >  generation from
> >  ; emitting debug info in the final output.
> > -; RUN: llc -mtriple x86_64-pc-linux-gnu %s -o - | FileCheck
> > -check-prefix=DEBUG-OUTPUT %s
> > +; RUN: llc < %s -mtriple x86_64-pc-linux-gnu -o - | FileCheck
> > -check-prefix=DEBUG-OUTPUT %s
> >  ; DEBUG-OUTPUT-NOT: .loc
> >  ; DEBUG-OUTPUT-NOT: {{.*}}.debug_info
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150515/fa2a5599/attachment.html>