[polly] r237431 - Give each memory access a reference ID

[Johannes Doerfert]

Hey Tobias,

some thoughts on this patch but nothing important.

On 05/15, Tobias Grosser wrote:
> Author: grosser
> Date: Fri May 15 04:58:32 2015
> New Revision: 237431
>  
> +  std::string IdName;
> +  raw_string_ostream IdNameStream(IdName);
> +  IdNameStream << "__polly_array_ref_ " << Identifier;
> +  IdNameStream.flush();
This seems overly complicated, what about:
  ("XXXX" + std::to_str(Identifier)).c_str();
> +  this->Id = isl_id_alloc(Ctx, IdName.c_str(), nullptr);

> +  int Identifier = 0;
> +
> -    MemAccs.push_back(new MemoryAccess(Access, AccessInst, this, SAI));
> +    MemAccs.push_back(
> +        new MemoryAccess(Access, AccessInst, this, SAI, Identifier));
> +    Identifier++;
MemAccs.size() would do the trick to I guess.

>      // We do not track locations for scalar memory accesses at the moment.
>      //
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 

Johannes Doerfert
Researcher / PhD Student

Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.31

Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065  : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150515/db861c72/attachment.sig>