[PATCH] Move easily derivable pointers optimization from CodeGenPrepare to RewriteStatepointPass

Philip Reames listmail at philipreames.com
Thu May 14 16:58:16 PDT 2015


I haven't had a chance to review the newly added bits in RewriteStatepointsForGC, but I want to comment on the CGP parts first.  I see no reason to remove this optimization.  If a statepoint is generated through a means other than RSForGC, this optimization is valid and useful.  Please update your patch to leave this code in CGP.

(If you chose to common the code in some way, that's fine.   I don't mean to discourage that.)


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9774

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list