[PATCH] [ConstantFolding] Fix wrong folding of intrinsic 'convert.from.fp16'.

Ahmed Bougacha ahmed.bougacha at gmail.com
Thu May 14 10:47:41 PDT 2015


Better indeed, go ahead!

-Ahmed


================
Comment at: lib/Analysis/ConstantFolding.cpp:1549
@@ -1546,3 +1548,3 @@
         APFloat::opStatus status =
-          Val.convert(APFloat::IEEEsingle, APFloat::rmNearestTiesToEven, &lost);
+          Val.convert(FPS, APFloat::rmNearestTiesToEven, &lost);
 
----------------
Nit: I'd put the Ty->getFltSemantics() here instead of in the variable, but I'm fine with both ways.

http://reviews.llvm.org/D9771

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list