[PATCH] [SDAG] Add SDNodes for umin, umax, smin and smax

Elena Demikhovsky elena.demikhovsky at intel.com
Thu May 14 03:58:20 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2258
@@ -2257,1 +2257,3 @@
 
+  if (NumValues == 1) {
+    Value *LHS, *RHS;
----------------
Why NumValues should be 1? You can do the same for each value and then merge them together.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2275
@@ +2274,3 @@
+
+    if (Opc != ISD::DELETED_NODE &&
+        DAG.getTargetLoweringInfo().isOperationLegalOrCustom(Opc, VT)) {
----------------
you can put the "while" (5 lines above) under this "if"

http://reviews.llvm.org/D9746

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list