[PATCH] [ValueTracking] Allow min/max detection to see through casts.

James Molloy james.molloy at arm.com
Thu May 14 02:55:52 PDT 2015


Hi Philip, David,

Thanks for your review! I've updated the diff. I looked for public versions of those helper functions but couldn't find them - I didn't think to check ConstantExpr! :(

All comments addressed. The only thing I'm not too keen on is the const_cast, I feel like raptors will come and attack me whenever it's used. But without it the "const" goes viral and takes over everything, including the return values "LHS" and "RHS".

James


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9748

Files:
  include/llvm/Analysis/ValueTracking.h
  lib/Analysis/ValueTracking.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9748.25762.patch
Type: text/x-patch
Size: 4839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150514/375f06a7/attachment.bin>


More information about the llvm-commits mailing list