[llvm] r237354 - [AArch64] Slight naming changes and comments for AArch64NamedImmMapper

Vladimir Sukharev vladimir.sukharev at arm.com
Thu May 14 02:50:15 PDT 2015


Author: vsukharev
Date: Thu May 14 04:50:14 2015
New Revision: 237354

URL: http://llvm.org/viewvc/llvm-project?rev=237354&view=rev
Log:
[AArch64] Slight naming changes and comments for AArch64NamedImmMapper

Reviewers: echristo

Subscribers: llvm-commits

Follow-up to: http://reviews.llvm.org/D8496#158595

Relates to: http://reviews.llvm.org/rL235089

Modified:
    llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h

Modified: llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h?rev=237354&r1=237353&r2=237354&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h (original)
+++ llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h Thu May 14 04:50:14 2015
@@ -280,15 +280,16 @@ struct AArch64NamedImmMapper {
   struct Mapping {
     const char *Name;
     uint32_t Value;
-    uint64_t AvailableForFeatures;
-    // empty AvailableForFeatures means "always-on"
+    uint64_t FeatureBitSet;  // Set of features this mapping is available for
+    // Zero value of FeatureBitSet means the mapping is always available
+
     bool isNameEqual(std::string Other, uint64_t FeatureBits=~0ULL) const {
-      if (AvailableForFeatures && !(AvailableForFeatures & FeatureBits))
+      if (FeatureBitSet && !(FeatureBitSet & FeatureBits))
         return false;
       return Name == Other;
     }
     bool isValueEqual(uint32_t Other, uint64_t FeatureBits=~0ULL) const {
-      if (AvailableForFeatures && !(AvailableForFeatures & FeatureBits))
+      if (FeatureBitSet && !(FeatureBitSet & FeatureBits))
         return false;
       return Value == Other;
     }
@@ -298,7 +299,9 @@ struct AArch64NamedImmMapper {
   AArch64NamedImmMapper(const Mapping (&Mappings)[N], uint32_t TooBigImm)
     : Mappings(&Mappings[0]), NumMappings(N), TooBigImm(TooBigImm) {}
 
+  // Maps value to string, depending on availability for FeatureBits given
   StringRef toString(uint32_t Value, uint64_t FeatureBits, bool &Valid) const;
+  // Maps string to value, depending on availability for FeatureBits given
   uint32_t fromString(StringRef Name, uint64_t FeatureBits, bool &Valid) const;
 
   /// Many of the instructions allow an alternative assembly form consisting of





More information about the llvm-commits mailing list