[PATCH] Extend EarlyCSE to handle basic cases from JumpThreading and CVP

Philip Reames listmail at philipreames.com
Wed May 13 16:13:41 PDT 2015


================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:490
@@ +489,3 @@
+                  ToUpdate.push_back(IU);
+            for (Instruction *UserI : ToUpdate) {
+              DEBUG(dbgs() << "EarlyCSE CVP: Replace dominated use of '"
----------------
dberlin wrote:
> Can you common this part with GVN's replaceAllDominatedUsesWith?
> 
> (IE just move that function somewhere common and use it?)
Absolutely.  Didn't know that existed.  Would it make sense to put that directly on Value?  Or would you rather see it as a helper function in Local.h or someplace similar?

http://reviews.llvm.org/D9763

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list