[PATCH] Implement `internal_start/join_thread` on Mac OS X

[Ismail Pazarbasi]

================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:340
@@ +339,3 @@
+void *internal_start_thread(void(*func)(void *arg), void *arg) {
+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 80000
+  // Start the thread with signals blocked, otherwise it can steal user signals.
----------------
glider wrote:
> Why is this disabled on certain iOS versions?
> Do we really need TSan on iOS? (note that the shadow memory overhead is quite big and the 32-bit address space may be too little).
I didn't try porting TSan to iOS, but I thought about trying it out for iPhone 6, which has 64-bit processor. I have no idea whether this is possible, as I didn't investigate it in detail.

We must get it working reliably on Mac OS X first. Therefore, it might be better to replace this line with:
  #if TARGET_OS_MAC && !TARGET_OS_IPHONE && !TARGET_IPHONE_SIMULATOR

http://reviews.llvm.org/D9638

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/