[PATCH] [RewriteStatepointsForGC] Extend base pointer to handle more cases w/vectors

[Pat Gavlin]

================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:304
@@ +303,3 @@
+    if (isa<ConstantInt>(Index) && isa<ConstantInt>(InsertIndex) &&
+        Index != InsertIndex)
+      return findBaseOfVector(IEI->getOperand(0), Index);
----------------
reames wrote:
> pgavlin wrote:
> > Isn't `Index != InsertIndex` redundant?
> Technically, yes, but I think the code would be far less obvious without it.  I'd prefer to leave it.  Do you object?
Somewhat: redundant checks tend to leave me wondering whether or not I missed a change between the checks. Personal preference would be to remove the redundant check, but I don't feel too strongly here.

http://reviews.llvm.org/D9676

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/