[PATCH] [ARM] Use AEABI aligned function variants

John Brawn john.brawn at arm.com
Tue May 12 06:14:08 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/ARM/ARMSelectionDAGInfo.cpp:42
@@ +41,3 @@
+  // Libcall is an AEABI function.
+  if (std::strncmp(TLI->getLibcallName(LC), "__aeabi", 7) != 0)
+    return SDValue();
----------------
jroelofs wrote:
> I think @asl is suggesting:
> 
> ```
> if (!Subtarget.isAAPCS_ABI() ||
>     std::strncmp(TLI->getLibcallName(LC), "__aeabi", 7) != 0)
> ```
> 
> here.
Ah, I see. Seems somewhat redundant to me (we would only get an aeabi function if the subtarget is already aapcs), and it's not like this is a time-critical function where avoiding a strncmp may be a good idea. I'll leave it as-is.

http://reviews.llvm.org/D8060

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list