[PATCH][LNT] Fix upgrade_3_to_4 and upgrade_4_to_5 to also work on Postgres

Kristof Beyls kristof.beyls at arm.com
Tue May 12 03:28:49 PDT 2015


Yes, I've tested this with both sqlite and Postgres.
Now committed as r237110.

Thanks,

Kristof

> -----Original Message-----
> From: Chris Matthews [mailto:chris.matthews at apple.com]
> Sent: 11 May 2015 17:01
> To: James Molloy
> Cc: Kristof Beyls; llvm-commits
> Subject: Re: [PATCH][LNT] Fix upgrade_3_to_4 and upgrade_4_to_5 to also
> work on Postgres
> 
> I ran into this problem on our Postgres server.  We do have a flag in
> the test suite to enable Postgres tests, I think I might be the only
> person who tests that regularly though.
> 
> > On May 11, 2015, at 8:31 AM, James Molloy <James.Molloy at arm.com>
> wrote:
> >
> > Hi Kristof,
> >
> > Have you run this through the LNT regression tests? Quoting is
> > difficult to get right on all platforms (it's a real pity our DBMS
> > layer couldn't deal with that query!)
> >
> > If it passes the migration regression tests, it LGTM.
> >
> > James
> >
> > On 11 May 2015, at 16:02, Kristof Beyls <kristof.beyls at arm.com> wrote:
> >
> >> <lnt_quote_names.diff>
> >
> >
> > -- IMPORTANT NOTICE: The contents of this email and any attachments
> are confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy
> the information in any medium.  Thank you.
> >
> > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ,
> > Registered in England & Wales, Company No:  2557590 ARM Holdings plc,
> > Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in
> > England & Wales, Company No:  2548782
> >







More information about the llvm-commits mailing list