[PATCH] CodeGenPrepare: Don't match addressing modes through addrspacecast

Matt Arsenault Matthew.Arsenault at amd.com
Mon May 11 11:38:41 PDT 2015


In http://reviews.llvm.org/D9179#170167, @hfinkel wrote:

> In http://reviews.llvm.org/D9179#159696, @arsenm wrote:
>
> > I was wondering if this is the right place for the test, since there doesn't seem to be any checking for the built targets. I'm not sure what to do other than duplicate the test for the no-op addrspacecast and non-noop addrspacecast cases
>
>
> Yea; probably best to create a target-specific subdirectory (with an associated lit.local.cfg file) just like we have for test/Transforms/LoopVectorize.


Should I create an R600_X86 subdirectory or something like that that checks both targets? Or would duplicating be better?


http://reviews.llvm.org/D9179

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list