[PATCH] Add a "probe-stack" attribute

John Kåre Alsaker john.mailinglists at gmail.com
Sun May 10 21:01:43 PDT 2015


I undid a typo fix. Here's new patches.

On Tue, Apr 28, 2015 at 3:45 PM, John Kåre Alsaker
<john.mailinglists at gmail.com> wrote:
> Bump
>
> On Sat, Apr 11, 2015 at 12:11 AM, John Kåre Alsaker
> <john.mailinglists at gmail.com> wrote:
>> Bump.
>>
>> On Sat, Mar 21, 2015 at 8:33 PM, John Kåre Alsaker
>> <john.mailinglists at gmail.com> wrote:
>>> Here's a rebased patchset.
>>>
>>> On Sun, Feb 22, 2015 at 5:01 PM, John Kåre Alsaker
>>> <john.mailinglists at gmail.com> wrote:
>>>> Bump
>>>>
>>>> On Sat, Jan 17, 2015 at 9:57 AM, John Kåre Alsaker
>>>> <john.mailinglists at gmail.com> wrote:
>>>>> I have a patch to add __probestack to compiler-rt. No other such
>>>>> function have a configurable name, so I don't see why __probestack
>>>>> should be different.
>>>>>
>>>>> I'm not sure how to test for #3 as I don't think any calling
>>>>> convention has RAX as live-in.
>>>>>
>>>>> I don't know if #4 even handles the edge case(s), which is why I added
>>>>> an assertion, so I don't know how to test for those. I can add a test
>>>>> for the non-edge case though.
>>>>>
>>>>> The stack-probe-size attribute interacts as expected (it just controls
>>>>> the stack allocation size for which probes are required).
>>>>>
>>>>> On Fri, Jan 16, 2015 at 10:30 PM, Reid Kleckner <rnk at google.com> wrote:
>>>>>> On Fri, Jan 16, 2015 at 12:43 PM, David Majnemer <david.majnemer at gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> Reid, I'm not so sure.
>>>>>>>
>>>>>>> We already have a probe-stack-size attribute, how does this attribute
>>>>>>> interact with that one?  Which targets have a __probestack that can be
>>>>>>> called?
>>>>>>
>>>>>>
>>>>>> There aren't any targets that use __probestack. It's new this patch. Maybe
>>>>>> the attribute should take the symbol name as a value so it's user
>>>>>> controlled?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-probe-stack-attribute.patch
Type: text/x-patch
Size: 3171 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150511/0742d742/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-x86-Add-support-for-probe-stack.patch
Type: text/x-patch
Size: 3655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150511/0742d742/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-x86-Don-t-assume-that-RAX-is-never-live-in.patch
Type: text/x-patch
Size: 3804 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150511/0742d742/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-x86-Ensure-the-redzone-is-not-used-with-stack-probes.patch
Type: text/x-patch
Size: 2371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150511/0742d742/attachment-0003.bin>


More information about the llvm-commits mailing list