[PATCH] [DebugInfo] Add debug locations to constant SD nodes continued

Sergey Dmitrouk sdmitrouk at accesssoftek.com
Fri May 8 12:57:34 PDT 2015


In http://reviews.llvm.org/D9604#169183, @dblaikie wrote:

> FWIW I don't think LLVM has any rule that out/in parameters appear in any particular order (& even if it does' we could overload FindNodeOrInsertPos rather than having to add a default constructed DebugLoc() to so many call sites (at least at a glance it looks like a lot of them - what's the ratio/absolute number that are just passing the default?))


13 of 40 calls use `DebugLoc()`. I'm happy to change the calls if default argument/overload looks better in your opinion, just wasn't sure about intermixing in/out arguments.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9604

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list