[PATCH] Extend the statepoint intrinsic to allow statepoints to be marked as transitions from GC-aware code to code that is not GC-aware.

Philip Reames listmail at philipreames.com
Thu May 7 13:53:13 PDT 2015


LGTM w/the comment and test fixes mentioned.


================
Comment at: test/CodeGen/X86/statepoint-gctransition-call-lowering.ll:2
@@ +1,3 @@
+; RUN: llc < %s | FileCheck %s
+; This file contains a collection of basic tests to ensure we didn't
+; screw up normal call lowering when there are no deopt or gc arguments.
----------------
Stale comment.

================
Comment at: test/CodeGen/X86/statepoint-gctransition-call-lowering.ll:16
@@ +15,3 @@
+; CHECK-LABEL: test_i1_return
+; This is just checking that a i1 gets lowered normally when there's no extra
+; state arguments to the statepoint
----------------
Please add at least one test which includes transition arguments which get lowered, but dropped due to the noops.  I want to exercise the newly added code.

http://reviews.llvm.org/D9501

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list