[PATCH] Rename builder lldb-x86_64-ubuntu-14.04-cross-compilation to lldb-x86_64-ubuntu-14.04-android

Siva Chandra sivachandra at google.com
Thu May 7 12:44:21 PDT 2015


lgtm


================
Comment at: buildbot/osuosl/master/config/builders.py:757
@@ -756,3 +756,3 @@
          'factory': LLDBBuilder.getLLDBxcodebuildFactory()},
-        {'name': "lldb-x86_64-ubuntu-14.04-cross-compilation",
+        {'name': "lldb-x86_64-ubuntu-14.04-android",
          'slavenames': ["lldb-lab-linux01"],
----------------
This is how it should have been!

When you add a builder, it would be good to present associated bugs which requested such a builder. That way, we can discuss names there and not in code reviews. This is my personal preference anyway.

http://reviews.llvm.org/D9571

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list