[PATCH] [sanitizer][MIPS] Add --target flag for MIPS32

Sagar Thakur Sagar.Thakur at imgtec.com
Thu May 7 01:33:37 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: cmake/config-ix.cmake:187
@@ -186,3 +186,3 @@
       # regex for mipsel, mips64el
-      test_target_arch(mipsel "" "-mips32r2")
-      test_target_arch(mips64el "" "-mips64r2 -mabi=n64")
+      test_target_arch(mipsel "" "-mips32r2\t--target=mipsel-linux-gnu")
+      test_target_arch(mips64el "" "-mips64r2\t-mabi=n64")
----------------
sagar wrote:
> samsonov wrote:
> > sagar wrote:
> > > I used the tab escape sequence here because while generating asan tests I get the following error :
> > > 
> > > >Scanning dependencies of target Asan-mips64el-with-calls-Noinst-Test
> > > >[ 76%] Generating ASAN_NOINST_TEST_OBJECTS.gtest-all.cc.mips64el-with-calls.o
> > > >clang-3.7: error: unknown argument: '-mips64r2 -mabi=n64'
> > > 
> > Please test if you can provide multiple flags to `test_target_arch` function:
> >   test_target_arch(mips "" "-mips32r2" "--target=mips-linux-gnu")
> > 
> > If it doesn't work, we should fix it.
> I am able to give multiple flags to `test_target_arch` funtion.
> But with this the tests under AddressSanitizer-mips64-linux don't get the flags properly.
> Since cmake list elements are glued with a semicolon, this semicolon gets inserted in between the two mips flags which divides the compile command into two parts. Therefore I have replaced this semicolon in get_target_flags_for_arch with a tab.
Sorry this comment was sent by mistake. It was not getting deleted.

http://reviews.llvm.org/D9249

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list