[PATCH] YAML: Implement block scalar parsing

[Alex L]

2015-05-06 15:01 GMT-07:00 Duncan P. N. Exon Smith <dexonsmith at apple.com>:

>
> > On 2015 May 6, at 17:57, Alex L <arphaman at gmail.com> wrote:
> >
> >
> >   - You haven't added any new tests (although I see you've modified the
> >     old ones).  Do the current tests really cover everything you've
> >     changed here?  If not, please add some targeted ones.
> >
> > I did add a new test in the yaml parser unittest. I also did change the
> existing YAMLParser tests,
> > but since they were never actually ran before I think that it's kind of
> equivalent to the
> > addition of new tests.
>
> Can you turn them on in a separate commit?


I could do that, but I was planning to commit this after the YAMLParser
tests are enabled, so I guess
it would make sense for them to be in this commit. Otherwise the other
patch will have to be changed
if it will be committed after this one.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150506/434b12ed/attachment.html>