[PATCH] Sparc: Add the alternate address space load/store instructions.

James Y Knight jyknight at google.com
Wed May 6 15:06:11 PDT 2015


================
Comment at: lib/Target/Sparc/SparcInstr64Bit.td:488
@@ -487,3 +487,3 @@
 // ATOMICS.
-let Predicates = [Is64Bit], Constraints = "$swap = $rd" in {
-  def CASXrr: F3_1_asi<3, 0b111110, 0b10000000,
+let Predicates = [Is64Bit], Constraints = "$swap = $rd", asi = 0b10000000 in {
+  def CASXrr: F3_1_asi<3, 0b111110,
----------------
echristo wrote:
> Can you comment on the asi magic value here and why you put it as part of the let stmt?
That magic value was a "template" parameter to F3_1_asi before, but I wanted it to be a passed-in immediate, from the asm, for the other new uses of F3_1_asi.

http://reviews.llvm.org/D8904

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list