[PATCH] YAML: Implement block scalar parsing

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed May 6 15:00:29 PDT 2015


> On 2015 May 6, at 17:57, Alex L <arphaman at gmail.com> wrote:
> 
> 
> > +  Current = skip_while(&Scanner::skip_s_white, Current);
> > +  skipComment();
> 
> These two lines are both part of `scanToNextToken()`.  I wonder if you
> picked the right thing to extract?
> 
> I'm not sure what you mean by this. 'skipComment' is used here as well
> as in 'scanToNextToken', but the rest is different.

This:

    Current = skip_while(&Scanner::skip_s_white, Current)

looks equivalent to the code just prior to `skipComment()` in
`scanToNextToken()`.



More information about the llvm-commits mailing list