[PATCH] Lower invoke statepoints and gc.results tied to them.

Sanjoy Das sanjoy at playingwithpointers.com
Wed May 6 11:01:26 PDT 2015


Minor comments inline.


REPOSITORY
  rL LLVM

================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1030
@@ +1029,3 @@
+    SDValue Chain = DAG.getEntryNode();
+    res = RFV.getCopyFromRegs(DAG, FuncInfo, getCurSDLoc(), Chain, nullptr, V);
+    resolveDanglingDebugInfo(V, res);
----------------
LLVM Coding style is to use CamelCase starting with a upper case letter -- please change `res` to `Result` or something like that.

================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/StatepointLowering.cpp:672
@@ +671,3 @@
+    PointerType *CalleeType = cast<PointerType>(
+                                ImmutableStatepoint(I).actualCallee()->getType());
+    Type *RetTy = cast<FunctionType>(
----------------
The spacing here looks weird -- can you please run this bit through `clang-format`?

http://reviews.llvm.org/D7760

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list