[PATCH] Allow 0-weight branches in BranchProbabilityInfo.

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed May 6 10:44:38 PDT 2015


> On 2015 May 6, at 13:37, Hans Wennborg <hans at chromium.org> wrote:
> 
> On Wed, May 6, 2015 at 10:19 AM, Diego Novillo <dnovillo at google.com> wrote:
>> On Wed, May 6, 2015 at 10:09 AM, Duncan P. N. Exon Smith
>> <dexonsmith at apple.com> wrote:
>> 
>>> 
>>> This looks like `visitSwitch()`.  I don't see why we can't handle a
>>> weight of 0 here.
>>> 
>>> It would be easy to change `SelectionDAGBuilder::splitWorkItem` to be
>>> resilient to weights of 0 instead:
>> 
>> I was going for mechanical changes in this patch. I want to have
>> something that's easy to bisect if I happen to break something else.
>> 
>> Perhaps a followup patch?
> 
> This sounds reasonable to me. The switch part lgtm.

Sure, SGTM too.



More information about the llvm-commits mailing list