[PATCH] Refactor normalization for invokes in placestatepoints pass.

Philip Reames listmail at philipreames.com
Wed May 6 10:36:32 PDT 2015


With comment corrections, LGTM.


REPOSITORY
  rL LLVM

================
Comment at: lib/Transforms/Scalar/PlaceSafepoints.cpp:699
@@ +698,3 @@
+    // in basic block. We will get mallformed code after RAUW for the
+    // gc_relocate if one of this phi nodes uses result from the invoke.
+    if (InvokeInst *Invoke = dyn_cast<InvokeInst>(CS.getInstruction())) {
----------------
Comment is incorrect.  gc_result, not gc_relocate.

Also, spelling: malformed.

http://reviews.llvm.org/D9497

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list