[PATCH] [mips] Emit the .insn directive for empty basic blocks.

Daniel Sanders daniel.sanders at imgtec.com
Wed May 6 09:09:43 PDT 2015


LGTM with a couple nits.

> Also, this fixes some failures in our out-of-tree MIPS buildbots, for the

>  exception handling regression tests under: SingleSource/Regression/C++/EH


This should mention that it's the microMIPS buildbots in particular.


================
Comment at: test/CodeGen/Mips/insn-zero-size-bb.ll:5-6
@@ +4,4 @@
+
+; Verify that when we are in micromips or mips16, we do emit the .insn
+; directive for zero-sized (empty) basic blocks.
+
----------------
Nit: This comment isn't quite right since we emit .insn for empty BB's on all subtargets. I think you mean it only matters for microMIPS and MIPS16.

http://reviews.llvm.org/D9530

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list