[PATCH] Indirect call target profiling compiler-rt changes

Xinliang David Li davidxl at google.com
Tue May 5 22:06:38 PDT 2015


On Tue, May 5, 2015 at 7:17 PM, Betul Buyukkurt <betulb at codeaurora.org> wrote:
>> Other than some minor issues, I don't have other major issues with this
>> patch.
>>
>> Justin, can you help take a look at the patch? This patch is relatively
>> standalone, and can be checked in independently if there are no blocking
>> problems.
>
> It can not be checked in independently. There are no readers that'd read
> the data format emitted by this run time changes. I'll be responding to
> the comments and updating the patches for the related LLVM side changes
> tomorrow morning.
>

It is possible to write out header compatible to the old version for
now and enable it to be checked in independently.

David

> Thanks,
> -Betul
>
>> thanks,
>>
>> David
>>
>>
>> http://reviews.llvm.org/D9009
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>>
>
>



More information about the llvm-commits mailing list