[PATCH] [PowerPC]Adapt fast stack unwinding to work for Power.

hfinkel at anl.gov hfinkel at anl.gov
Tue May 5 20:32:55 PDT 2015


================
Comment at: /home/seurer/llvm/llvm-test/projects/compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.h:56
@@ +55,3 @@
+  // frames.
+  static const bool FAST_UNWIND_SHOULD_POP_FRAMES_TO_PC = true;
+#else
----------------
Kostya, can you please look at this (or ping the appropriate person)?

I talked to Bill about this offline, and he explained that there is nothing PowerPC-specific about needing to pop these extra frames to match the regular unwinder (he says the same is needed on all platforms). Maybe we should be changing this in general, or this is a deliberate optimization that PowerPC should just match (and adjust test cases as necessary?).

http://reviews.llvm.org/D9259

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list